(introspection) - Improve schema minification by removing meta types #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific fields contain meta-information about the schema that won't need to be included for `buildClientSchema(schema)` to create a valid schema for the given introspection information, specifically: - __Directive - __DirectiveLocation - __EnumValue - __InputValue - __Field - __Type - __TypeKind - __Schema
Instead of spreading arguments we can passthrough their name and drop the defaultValue field manually. This prevents fields like `description` and deprecation information from sticking around.
🦋 Changeset detectedLatest commit: ffba40a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jan 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes more superfluous information from the minified schema introspection JSON data that
minifyIntrospectionQuerygenerates. This has been checked to still be correctly parsed bybuildClientSchema.Set of changes